ci(pypi): split the PyPI release process #463
Conversation
.github/workflows/pypi-publish.yml
Outdated
| on: | ||
| release: | ||
| types: [published] | ||
| types: [released] |
There was a problem hiding this comment.
What's the difference here? 👀
|
Build failed. ❌ pre-commit FAILURE in 1m 56s |
mfocko
force-pushed
the
ci/pypi-release-fix
branch
from
cf2496c to
b223683
Compare
Related to packit/private#32 Signed-off-by: Matej Focko <[email protected]>
mfocko
force-pushed
the
ci/pypi-release-fix
branch
from
b223683 to
475c49e
Compare
.github/workflows/pypi-publish.yml
Outdated
| git fetch --prune --unshallow | ||
| git fetch --depth=1 origin +refs/tags/*:refs/tags/* |
There was a problem hiding this comment.
How come it worked until now without this?
There was a problem hiding this comment.
have no clue, maybe it was a change in the way github action checkouts the source? I could have a look how we got to this point, but I also think that we started without this and it got added at some point
There was a problem hiding this comment.
weren't the scm tools dropped since then? 👀 if it's related to setuptools_scm
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 57s |
.github/workflows/pypi-publish.yml
Outdated
| - name: Get history and tags for SCM versioning to work | ||
| run: | | ||
| git fetch --prune --unshallow | ||
| git fetch --depth=1 origin +refs/tags/*:refs/tags/* |
There was a problem hiding this comment.
Why not pass fetch-depth to the checkout action?
There was a problem hiding this comment.
I was actually checking the options they have, but I was not able to combine it with the first fetch --prune --unshallow
There was a problem hiding this comment.
What's the purpose of that command? If you simply want to do a full clone so that setuptools_scm works properly, you can set fetch-depth to 0. Or is there something else here?
Signed-off-by: Matej Focko <[email protected]>
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 57s |
3 participants
Related to packit/private#32